Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-slugify to 8.0.4 #110045

Closed
wants to merge 2 commits into from

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Feb 8, 2024

Proposed change

diff: un33k/python-slugify@v8.0.1...v8.0.4
mostly because of un33k/python-slugify#148

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@mib1185 mib1185 requested a review from a team as a code owner February 8, 2024 19:06
@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Feb 8, 2024
@mib1185 mib1185 marked this pull request as draft February 8, 2024 20:29
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Apr 10, 2024
@mib1185 mib1185 removed the stale label Apr 10, 2024
@mib1185 mib1185 marked this pull request as ready for review April 10, 2024 19:27
@joostlek
Copy link
Member

No files seem to have changed this PR?

@mib1185
Copy link
Contributor Author

mib1185 commented Apr 11, 2024

mehhh ... i thought this was an caching issue on my browser last night 🙈
but now i see there was a later PR #111284 already bumping slugify 😁

@mib1185 mib1185 closed this Apr 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@mib1185 mib1185 deleted the bump-python-slugify branch July 31, 2024 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants