Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-hpilo to 4.4.3 #110325

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Bump python-hpilo to 4.4.3 #110325

merged 2 commits into from
Feb 23, 2024

Conversation

Nirostar
Copy link
Contributor

@Nirostar Nirostar commented Feb 12, 2024

Proposed change

This should fix the problem here: #109581
The library fixed this already years ago (seveas/python-hpilo@6854475)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
    • (currently can't run them on my Windows machine but the CI pipeline is fine)
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

The issue with the deprecated and now removed ssl.wrap_socket function was fixed years ago in the library
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nirostar

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Nirostar
Copy link
Contributor Author

Sorry, I wasn't able to run the tests locally because I don't have access to a working Linux System atm. Can maybe some1 else check it?

@Nirostar Nirostar changed the title Update hpilo version to fix problems with the python upgrade (#109581) Fix problems with hpilo after the python upgrade by upgradingt the used library (#109581) Feb 13, 2024
@Nirostar Nirostar changed the title Fix problems with hpilo after the python upgrade by upgradingt the used library (#109581) Fix problems with hpilo after the python upgrade by upgrading the used library (#109581) Feb 13, 2024
@Nornode
Copy link

Nornode commented Feb 14, 2024

Sorry, I wasn't able to run the tests locally because I don't have access to a working Linux System atm. Can maybe some1 else check it?

How can I help out?

I tried your temp fix:
docker exec -it homeassistant bash -c "wget https://raw.githubusercontent.com/seveas/python-hpilo/5881ffab4fba6ea136176a92de58c710704e9653/hpilo.py -O /usr/local/lib/python3.12/site-packages/hpilo.py"
This seems to have fixed it.
Do you need me to verify it in any other way?

@Nirostar
Copy link
Contributor Author

Nirostar commented Feb 15, 2024

Sorry, I wasn't able to run the tests locally because I don't have access to a working Linux System atm. Can maybe some1 else check it?

How can I help out?

I tried your temp fix: docker exec -it homeassistant bash -c "wget https://raw.githubusercontent.com/seveas/python-hpilo/5881ffab4fba6ea136176a92de58c710704e9653/hpilo.py -O /usr/local/lib/python3.12/site-packages/hpilo.py" This seems to have fixed it. Do you need me to verify it in any other way?

Yeah, I also tried this and it works. I would love if some1 could run the autotest in the project. I can't get it running but I think it's Windows' fault. Nvmd. seems like they are executed by the CI pipeline.

@danielszilagyi
Copy link

@emontnemery would you mind approving this PR as the hpilo integration maintainer? It would fix the breaking issue present since 2024.2

@epenet epenet changed the title Fix problems with hpilo after the python upgrade by upgrading the used library (#109581) Bump python-hpilo to 4.4.3 Feb 23, 2024
Copy link

@stevehop stevehop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by restoring an old HA snapshot dating before manual update to python-hpilo v4.4.3 and applying this PR as a custom component.

Confirmed that this updates python-hpilo to v4.4.3 and fixes the HA integration

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nirostar 👍

@gjohansson-ST gjohansson-ST merged commit 2ff0102 into home-assistant:dev Feb 23, 2024
53 checks passed
@vans113
Copy link

vans113 commented Feb 24, 2024

I'm still having issues with this. I am on the latest build. I am running HA as a VM not on docker also if that matters.

@gjohansson-ST
Copy link
Member

Don't discuss here, move that to the issue if needed or even open a new one.
Not sure what you mean by build (are you running dev?). This fix won't be released until 2024.3

@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HP ILO integration not working in most recent update
7 participants