-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-hpilo to 4.4.3 #110325
Bump python-hpilo to 4.4.3 #110325
Conversation
The issue with the deprecated and now removed ssl.wrap_socket function was fixed years ago in the library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sorry, I wasn't able to run the tests locally because I don't have access to a working Linux System atm. Can maybe some1 else check it? |
How can I help out? I tried your temp fix: |
Yeah, I also tried this and it works. |
@emontnemery would you mind approving this PR as the hpilo integration maintainer? It would fix the breaking issue present since 2024.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by restoring an old HA snapshot dating before manual update to python-hpilo v4.4.3 and applying this PR as a custom component.
Confirmed that this updates python-hpilo to v4.4.3 and fixes the HA integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Nirostar 👍
I'm still having issues with this. I am on the latest build. I am running HA as a VM not on docker also if that matters. |
Don't discuss here, move that to the issue if needed or even open a new one. |
Proposed change
This should fix the problem here: #109581
The library fixed this already years ago (seveas/python-hpilo@6854475)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
Documentation added/updated for www.home-assistant.ioIf the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: