Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading of more then 1 defined Apprise URL #110868

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

caronc
Copy link
Contributor

@caronc caronc commented Feb 18, 2024

Proposed change

This resolves #110242

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

HA after v2024.2.1 no longer passes a string and sends a list instead. This fix handles this case.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

joostlek commented Feb 18, 2024

@caronc, in what age are you living? Isort has been replaced by ruff a looooong time ago. :P

@caronc caronc force-pushed the 110242-apprise-integration-fix branch from 638fc52 to 2ef963e Compare February 18, 2024 16:40
@caronc
Copy link
Contributor Author

caronc commented Feb 18, 2024

@caronc, in what age are you living? Isort has been replaced by ruff a looooong time ago. :P

@joostlek no worries, rolled back. It was in my notes from the last PR made to HA (looooong ago)

Copy link
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raman325 raman325 added this to the 2024.2.3 milestone Feb 18, 2024
@edenhaus edenhaus merged commit 31ce432 into home-assistant:dev Feb 19, 2024
23 checks passed
@caronc caronc deleted the 110242-apprise-integration-fix branch February 19, 2024 13:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apprise integration fails to set up multiple services
5 participants