-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading of more then 1 defined Apprise URL #110868
Merged
edenhaus
merged 3 commits into
home-assistant:dev
from
caronc:110242-apprise-integration-fix
Feb 19, 2024
Merged
Allow loading of more then 1 defined Apprise URL #110868
edenhaus
merged 3 commits into
home-assistant:dev
from
caronc:110242-apprise-integration-fix
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: apprise
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Feb 18, 2024
@caronc, in what age are you living? Isort has been replaced by ruff a looooong time ago. :P |
caronc
force-pushed
the
110242-apprise-integration-fix
branch
from
February 18, 2024 16:40
638fc52
to
2ef963e
Compare
caronc
force-pushed
the
110242-apprise-integration-fix
branch
from
February 18, 2024 16:49
2ef963e
to
53e5aa9
Compare
raman325
reviewed
Feb 18, 2024
raman325
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
edenhaus
approved these changes
Feb 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
integration: apprise
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This resolves #110242
Type of change
Additional information
HA after v2024.2.1 no longer passes a string and sends a list instead. This fix handles this case.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: