-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Shelly RPC RSSI sensor removal #111035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @balloob, @bieniu, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
a590212
to
2311660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @thecode
Thanks @thecode |
Pulling this from the milestone, as it causes build issues (as it relies on other changes not in the current stable release for the tests). Will be part of 2024.3 instead. |
Proposed change
#108390 removes the RPC (Shelly Gen2) RSSI sensor if the first WiFi station is disabled, Shelly Plus/Pro devices supports two WiFi connections and it is possible to enable the second one and disable the first one (I am using this as normal testing to cause a device to connect to a far AP).
https://shelly-api-docs.shelly.cloud/gen2/ComponentsAndServices/WiFi#configuration
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: