Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shelly RPC RSSI sensor removal #111035

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

thecode
Copy link
Member

@thecode thecode commented Feb 20, 2024

Proposed change

#108390 removes the RPC (Shelly Gen2) RSSI sensor if the first WiFi station is disabled, Shelly Plus/Pro devices supports two WiFi connections and it is possible to enable the second one and disable the first one (I am using this as normal testing to cause a device to connect to a far AP).
https://shelly-api-docs.shelly.cloud/gen2/ComponentsAndServices/WiFi#configuration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@thecode thecode added this to the 2024.2.3 milestone Feb 20, 2024
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@home-assistant home-assistant bot marked this pull request as draft February 20, 2024 19:34
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @balloob, @bieniu, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@thecode thecode force-pushed the shelly-fix-rssi-sensor branch from a590212 to 2311660 Compare February 20, 2024 19:37
@thecode thecode marked this pull request as ready for review February 20, 2024 19:38
Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @thecode

@bdraco
Copy link
Member

bdraco commented Feb 21, 2024

Thanks @thecode

@bdraco bdraco merged commit c690a9d into home-assistant:dev Feb 21, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
@frenck frenck removed this from the 2024.2.3 milestone Feb 22, 2024
@frenck
Copy link
Member

frenck commented Feb 22, 2024

Pulling this from the milestone, as it causes build issues (as it relies on other changes not in the current stable release for the tests).

Will be part of 2024.3 instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shelly Plus 1PM missing rssi sensor
6 participants