Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump roombapy to 1.8.1 #114478

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Bump roombapy to 1.8.1 #114478

merged 5 commits into from
Apr 2, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Mar 30, 2024 •
edited
Loading

Proposed change

pschmitt/roombapy@1.6.13...1.8.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @pschmitt, @cyr-ius, @shenxn, @Xitee1, @Orhideous, mind taking a look at this pull request as it has been labeled with an integration (roomba) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roomba can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roomba Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek marked this pull request as draft March 30, 2024 11:31
@joostlek joostlek changed the title Bump roombapy to 1.7.0 Bump roombapy to 1.8.0 Apr 1, 2024
@joostlek joostlek marked this pull request as ready for review April 1, 2024 20:34
@Orhideous
Copy link
Contributor

@joostlek Please, bump again this library to 1.8.1 :)

@joostlek joostlek changed the title Bump roombapy to 1.8.0 Bump roombapy to 1.8.1 Apr 1, 2024
@joostlek joostlek added this to the 2024.4.0 milestone Apr 1, 2024
Orhideous
Orhideous approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@Orhideous Orhideous left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, because this is a housekeeping release.

TheJulianJES
TheJulianJES reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure seems like something that should be fixed.
(likely related to pschmitt/roombapy#277)

@bdraco bdraco marked this pull request as draft April 2, 2024 02:53
@joostlek joostlek marked this pull request as ready for review April 2, 2024 08:31
@joostlek joostlek merged commit 21c7cc3 into home-assistant:dev Apr 2, 2024
35 checks passed
@joostlek joostlek deleted the roombapy-170 branch April 2, 2024 09:15
frenck pushed a commit that referenced this pull request Apr 2, 2024
@joostlek @frenck
Bump roombapy to 1.8.1 (#114478)
18b6de5 
* Bump roombapy to 1.7.0

* Bump

* Bump

* Fix
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheJulianJES TheJulianJES TheJulianJES approved these changes

@Orhideous Orhideous Orhideous approved these changes

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed dependency integration: roomba Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@joostlek @Orhideous @balloob @TheJulianJES @frenck