-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sensor for Refoss Integration #116965
Add Sensor for Refoss Integration #116965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a new platform for the integration, let's add tests for it.
Not all documents in official standards require testing,Untested files have been added to .coveragerc。 VID_20240521_090142.mp4 |
…into feature/refoss-add-sensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We require that the PR are as small as possible and this PR can be split into two.
Please bump the library in a separate PR and leave this one in draft until the other one is merged
Hi, based on your suggestion, the library PR ( #118450) is merged, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You checked the checkmark, that you added tests but this PR doesn't include tests. Please add the tests to this PR
Does each PR require tests? |
Drafting as not all requested changes are implemented |
ok,Modified |
@edenhaus Thanks,case processed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashionky 👍
Breaking change
Proposed change
Add Refoss Sensor
library pr: #118450
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: