Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sensor for Refoss Integration #116965

Merged
merged 18 commits into from
Jun 20, 2024

Conversation

ashionky
Copy link
Contributor

@ashionky ashionky commented May 7, 2024

Breaking change

Proposed change

Add Refoss Sensor
library pr: #118450

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@ashionky ashionky changed the title Add Refoss Sensor Add Sensor for Refoss Integration May 7, 2024
@ashionky ashionky marked this pull request as draft May 8, 2024 03:31
@ashionky ashionky marked this pull request as ready for review May 8, 2024 03:31
@ashionky ashionky marked this pull request as draft May 9, 2024 09:33
@ashionky ashionky marked this pull request as ready for review May 9, 2024 09:33
@ashionky ashionky changed the title Add Sensor for Refoss Integration Add Sensor Platform for Refoss Integration May 15, 2024
Copy link
Contributor

@PeteRager PeteRager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new platform for the integration, let's add tests for it.

@ashionky
Copy link
Contributor Author

ashionky commented May 21, 2024

Since this is a new platform for the integration, let's add tests for it.

Not all documents in official standards require testing,Untested files have been added to .coveragerc。

VID_20240521_090142.mp4

@ashionky ashionky requested a review from PeteRager May 21, 2024 00:44
@ashionky ashionky changed the title Add Sensor Platform for Refoss Integration Add Sensor for Refoss Integration May 24, 2024
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We require that the PR are as small as possible and this PR can be split into two.
Please bump the library in a separate PR and leave this one in draft until the other one is merged

@ashionky ashionky marked this pull request as ready for review May 31, 2024 00:39
@home-assistant home-assistant bot requested a review from edenhaus May 31, 2024 00:39
@ashionky
Copy link
Contributor Author

ashionky commented Jun 6, 2024

We require that the PR are as small as possible and this PR can be split into two. Please bump the library in a separate PR and leave this one in draft until the other one is merged

Hi, based on your suggestion, the library PR ( #118450) is merged, thanks!

homeassistant/components/refoss/const.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 6, 2024 07:26
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You checked the checkmark, that you added tests but this PR doesn't include tests. Please add the tests to this PR

@joostlek joostlek changed the title Add Sensor for Refoss Integration Add Sensor for Refoss Integration Jun 6, 2024
@ashionky
Copy link
Contributor Author

ashionky commented Jun 7, 2024

You checked the checkmark, that you added tests but this PR doesn't include tests. Please add the tests to this PR

Does each PR require tests?
But other PRs do not require tests

@edenhaus
Copy link
Contributor

edenhaus commented Jun 10, 2024

You checked the checkmark, that you added tests but this PR doesn't include tests. Please add the tests to this PR

Does each PR require tests? But other PRs do not require tests

Screenshot from the PR description:
image

You checked the checkbox to mark that you have added tests. Where are the new tests?

homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/sensor.py Outdated Show resolved Hide resolved
@ashionky ashionky marked this pull request as ready for review June 11, 2024 06:01
@home-assistant home-assistant bot requested a review from edenhaus June 11, 2024 06:01
@edenhaus
Copy link
Contributor

Drafting as not all requested changes are implemented

@edenhaus edenhaus marked this pull request as draft June 12, 2024 08:26
@ashionky ashionky marked this pull request as ready for review June 13, 2024 01:35
@ashionky
Copy link
Contributor Author

Drafting as not all requested changes are implemented

ok,Modified

homeassistant/components/refoss/strings.json Outdated Show resolved Hide resolved
homeassistant/components/refoss/strings.json Outdated Show resolved Hide resolved
homeassistant/components/refoss/strings.json Outdated Show resolved Hide resolved
homeassistant/components/refoss/strings.json Outdated Show resolved Hide resolved
homeassistant/components/refoss/strings.json Outdated Show resolved Hide resolved
homeassistant/components/refoss/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 20, 2024 08:07
@ashionky
Copy link
Contributor Author

@edenhaus Thanks,case processed

@ashionky ashionky marked this pull request as ready for review June 20, 2024 08:15
@home-assistant home-assistant bot requested a review from edenhaus June 20, 2024 08:15
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashionky 👍

@edenhaus edenhaus merged commit 3224224 into home-assistant:dev Jun 20, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants