Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump here-routing to 1.0.1 #120877

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

eifinger
Copy link
Contributor

@eifinger eifinger commented Jun 30, 2024

Proposed change

Changes: eifinger/here_routing@v0.2.0...v1.0.1

Since here-routing was modelled after frencks adguard lib the same fix as suggested in #120583 (comment) was applied in commit eifinger/here_routing@029814b

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is failing. Can you please look into it?

@eifinger
Copy link
Contributor Author

A test is failing. Can you please look into it?

That is a Sonos test. What would you like me to do?

Copy link
Contributor

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @eifinger! The rebase worked.

Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES
Copy link
Member

Apprise CI failure is unrelated and already failed on dev.

@TheJulianJES TheJulianJES merged commit eceecbb into home-assistant:dev Jun 30, 2024
34 of 35 checks passed
carlosmazzei pushed a commit to carlosmazzei/core that referenced this pull request Jun 30, 2024
@eifinger eifinger mentioned this pull request Jul 1, 2024
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
@frenck frenck added this to the 2024.7.0 milestone Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Here Travel Time: Detected blocking call to listdir with args inside the event loop
4 participants