-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESPHome] Disable dashboard based update entities by default #120907
Conversation
Hey there @OttoWinter, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Converting this PR to draft for now, I think we need to discuss the approach here first. As this is trying to manage a UI issue. ../Frenck |
Discussed offline and good to go. |
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
How are users supposed to update their devices now? Through the ESPHome Dashboard? I am just bringing this point because the update entities, although overwhelming 90% of the times, were helpful when I finally decided to update my devices. I could simply click in Update in each one and leave them running. It would take an hour but everything would end up being updated, whereas in the dashboard I can only do one at a time, and I need to keep monitoring it. |
You can still enable the entities if you want. You can also in the dashboard use the "Update All" feature, to avoid having to do many clicks. The reasoning here is that we are no longer emphasizing the constant updates for ESPHome devices. A minor patch release of ESPHOMe doesn't require a whole rebuild of your device as most likely, it won't run any new code. |
That makes sense and sounds like a good compromise. As a user, I totally support it. It also gives me a bit more peace of mind regarding the number of flashes my ESP devices can still take. |
Unfortunatelly, I have more Offline/Draft devices than online (eg. multiple dev variant for a device) The 'Update all' button tries to recompile those offline devices as well. As of now it would be nice for the user to mark them as 'Draft' or 'Out of use' to keep tidy the dashboard and don't recompile them unnecessarily... |
Yeah, now I remember why Update all wasn't useful for me. Also, I think you had to keep the dashboard open in your browser all the time otherwise it would stop the update process, if I remember well. |
I have over 50 nodes and "Update All" 100% never finishes updating my nodes. For some unknown reason it fails after just a few nodes. Starting it over starts from scratch as far as I recall so I am left with triggering updates manually. I now have a node-red flow that triggers the updates by category with me just pressing the button for whatever category I want to update. |
Right, in short, Update all button in the ESPHome Dashboard hasn't much use. But anyway, we can just re-enable the update entities. This is simple enough. |
Breaking change
Proposed change
These dashboard based update entities were overwhelming users that had many ESPHome devices on their network. There is no reason that every device needs to be fully up to date with the latest ESPHome release if it is in a working state and there are no vulnerabilities that have been fixed in recent releases.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: