Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pynx584 to 0.8.2 #120910

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Bump pynx584 to 0.8.2 #120910

merged 1 commit into from
Jul 5, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Jul 1, 2024

Proposed change

Bump pynx584 to 0.8.2
kk7ds/pynx584@cad0f8a...master

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member Author

joostlek commented Jul 1, 2024

@kk7ds I assume you are still a home assistant user, are you able to test this change?

@kk7ds
Copy link
Contributor

kk7ds commented Jul 1, 2024

@joostlek I actually never was, I just did a bunch of integration of some of my libraries for someone else who wanted to run it (but no longer does). But yeah, I can't test this, sorry.

@joostlek
Copy link
Member Author

joostlek commented Jul 1, 2024

Are there any changes we have to take into account when using this library? I wasn't expecting to bump it 3 minor versions

@kk7ds
Copy link
Contributor

kk7ds commented Jul 1, 2024

I think that's hard to say without me reviewing the hass code. I generally try not to break APIs when possible, but I'm pretty surprised to see that people were still running 0.5 since many of the changes since then have been at the request of hass users. Perhaps they were overriding the dep locally, I'm not sure. looks like 0.5 was kk7ds/pynx584 so you can diff and see if that looks like it would break anything. I was sure hass was using the eventqueue and such... but much of the change was to dockerfile, docs, tests.

@joostlek joostlek marked this pull request as ready for review July 1, 2024 17:32
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 4, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 0088765 into home-assistant:dev Jul 5, 2024
39 checks passed
@joostlek joostlek deleted the pynx584-082 branch July 5, 2024 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency integration: nx584 Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants