Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentherm_gw.binary_sensor to use entity_description #121969

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

mvn23
Copy link
Contributor

@mvn23 mvn23 commented Jul 15, 2024

Proposed change

Update opentherm_gw to use entity descriptions for its binary_sensor entities.
Partial fix for #119271

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 15, 2024 18:04
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this integration has a lot of potential to make use of new features within home assistant so we can maintain a nice consistent user experience between integrations, if you have questions about this or want to think with me about it, feel free to hmu on discord :)

homeassistant/components/opentherm_gw/entity.py Outdated Show resolved Hide resolved
homeassistant/components/opentherm_gw/entity.py Outdated Show resolved Hide resolved
homeassistant/components/opentherm_gw/entity.py Outdated Show resolved Hide resolved
homeassistant/components/opentherm_gw/entity.py Outdated Show resolved Hide resolved
homeassistant/components/opentherm_gw/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/opentherm_gw/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/opentherm_gw/binary_sensor.py Outdated Show resolved Hide resolved
@joostlek
Copy link
Member

(Oh and sorry for reviewing before you put it as ready, I like revamping integrations)

@mvn23
Copy link
Contributor Author

mvn23 commented Aug 19, 2024

(Oh and sorry for reviewing before you put it as ready, I like revamping integrations)

No problem, I appreciate the feedback. I'm planning a few follow-up PRs already to take care of the rest of the integration, can I tag you in those as well later on?

@joostlek
Copy link
Member

We usually don't like tagging and we like to keep PRs with a mindset of "anyone can pick them up". But I will see them anyway as I check all PRs :)

Address feedback
@mvn23 mvn23 marked this pull request as ready for review August 20, 2024 07:48
@home-assistant home-assistant bot requested a review from joostlek August 20, 2024 07:48
@joostlek joostlek merged commit e81aa1c into home-assistant:dev Aug 20, 2024
25 of 26 checks passed
@mvn23 mvn23 deleted the binary-sensor-update branch August 20, 2024 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants