-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update opentherm_gw.binary_sensor to use entity_description #121969
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Move common entity code to entity.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this integration has a lot of potential to make use of new features within home assistant so we can maintain a nice consistent user experience between integrations, if you have questions about this or want to think with me about it, feel free to hmu on discord :)
(Oh and sorry for reviewing before you put it as ready, I like revamping integrations) |
No problem, I appreciate the feedback. I'm planning a few follow-up PRs already to take care of the rest of the integration, can I tag you in those as well later on? |
We usually don't like tagging and we like to keep PRs with a mindset of "anyone can pick them up". But I will see them anyway as I check all PRs :) |
Address feedback
Proposed change
Update opentherm_gw to use entity descriptions for its binary_sensor entities.
Partial fix for #119271
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: