-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump openwebifpy to 4.2.7 #123995
Bump openwebifpy to 4.2.7 #123995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you confirm the new code fixes the issue?
if len(result["events"])
would throw the same error when the events
key isn't included, right? You're still trying to access result["events"])
that caused the issue in the first place.
If result["events"]
would exist, but be empty, the previous code should already have worked. It would already return an empty dictionary then, as there's nothing to loop through. I don't think the added code fixes an actual issue.
Looking at trace in issue #123345, I think you'd have to check that the "events"
key exists: "events" in result
OR result.get("events")
to fall-back to None
(and adjust the rest of your code accordingly).
Thank you, you are right. I have added the checks, so that now everything should be catched. |
* Bump openwebifpy to 4.2.6 * Bump openwebifpy to 4.2.7 --------- Co-authored-by: J. Nick Koston <nick@koston.org>
Proposed change
This bumps openwebifpy to 4.2.7.
https://github.com/autinerd/openwebifpy/releases/tag/4.2.6
https://github.com/autinerd/openwebifpy/releases/tag/4.2.7
It would be good if this could be added to a minor release.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: