Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Exclude aiohappyeyeballs from license check" #124116

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 17, 2024

Reverts #124041

This should no longer be needed

@bdraco bdraco requested a review from a team as a code owner August 17, 2024 13:40
@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Aug 17, 2024
@bdraco bdraco added the ci-full-run Marks a PR to trigger a full CI run (instead of partial) label Aug 17, 2024
@bdraco bdraco closed this Aug 17, 2024
@bdraco bdraco reopened this Aug 17, 2024
@bdraco
Copy link
Member Author

bdraco commented Aug 17, 2024

The python env isn't getting rebuilt so its still checking .6 instead of .7

@bdraco
Copy link
Member Author

bdraco commented Aug 17, 2024

@bdraco
Copy link
Member Author

bdraco commented Aug 17, 2024

Longer term, scripts/licenses.py likely needs to be added to the python env hash. For now, to fix the CI, I think we can merge as-is as it will solve the issue in #124115

@bdraco bdraco merged commit 1bab373 into dev Aug 17, 2024
71 of 73 checks passed
@bdraco bdraco deleted the revert-124041-aiohappyeyeballs branch August 17, 2024 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2024
@balloob balloob added this to the 2024.8.3 milestone Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked ci-full-run Marks a PR to trigger a full CI run (instead of partial) cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants