Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch platform to Nice G.O. #124237

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

IceBotYT
Copy link
Contributor

@IceBotYT IceBotYT commented Aug 19, 2024

Proposed change

Adds the switch platform to Nice G.O.
Allows the user to turn on/off vacation mode, preventing operation of the door from physical control points (e.g. wall station, wireless keypad, car remote control, HomeLink, etc.)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

homeassistant/components/nice_go/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/nice_go/switch.py Outdated Show resolved Hide resolved
@IceBotYT IceBotYT marked this pull request as ready for review August 19, 2024 19:05
tests/components/nice_go/test_switch.py Outdated Show resolved Hide resolved
tests/components/nice_go/test_switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 19, 2024 19:07
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@IceBotYT IceBotYT marked this pull request as ready for review August 19, 2024 19:22
@home-assistant home-assistant bot requested a review from joostlek August 19, 2024 19:22
@joostlek joostlek merged commit 20f7af2 into home-assistant:dev Aug 19, 2024
22 checks passed
@IceBotYT IceBotYT deleted the nice-go-switch branch August 19, 2024 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants