Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary package constraint on flexparser and pint to fix CI #130016

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Nov 7, 2024

Proposed change

flexparser 0.4 was released a few hours ago, which breaks pint.
https://pypi.org/project/flexparser/#history

See hgrecco/pint#1969

Sample CI failure:
https://github.com/home-assistant/core/actions/runs/11716301319/job/32634642240?pr=130005
https://github.com/home-assistant/core/actions/runs/11718640751/job/32640345287?pr=129963

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet requested a review from a team as a code owner November 7, 2024 08:18
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Nov 7, 2024
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pin both flexparser and pint to exact versions for now.

homeassistant/package_constraints.txt Outdated Show resolved Hide resolved
script/gen_requirements_all.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 7, 2024 08:24
@home-assistant
Copy link

home-assistant bot commented Nov 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cdce8p cdce8p added this to the 2024.11.1 milestone Nov 7, 2024
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@epenet epenet marked this pull request as ready for review November 7, 2024 08:25
@home-assistant home-assistant bot requested a review from cdce8p November 7, 2024 08:25
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epenet 👍🏻

@cdce8p cdce8p changed the title Add temporary package constaint on flexparser to fix CI Add temporary package constaint on flexparser and pint to fix CI Nov 7, 2024
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@epenet epenet changed the title Add temporary package constaint on flexparser and pint to fix CI Add temporary package constraint on flexparser and pint to fix CI Nov 7, 2024
@epenet epenet mentioned this pull request Nov 7, 2024
19 tasks
@cdce8p cdce8p merged commit a657b9b into home-assistant:dev Nov 7, 2024
42 checks passed
@epenet epenet deleted the 20241107-0915 branch November 7, 2024 08:57
@cdce8p cdce8p mentioned this pull request Nov 7, 2024
19 tasks
@cdce8p cdce8p removed this from the 2024.11.1 milestone Nov 7, 2024
@cdce8p
Copy link
Member

cdce8p commented Nov 7, 2024

Removed the milestone since pint 0.24.4 was released an hour ago. See #130070.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants