Add Ohme integration #132574
Merged
Add Ohme integration #132574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
8 tasks
MartinHjelmare
previously requested changes
Dec 7, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
requested changes
Dec 13, 2024
joostlek
reviewed
Dec 14, 2024
joostlek
requested changes
Dec 14, 2024
| "password": "[%key:common::config_flow::data::password%]" | ||
| }, | ||
| "data_description": { | ||
| "email": "Enter the email address associated with your Ohme account. This should not be a social account (eg. Google).", |
There was a problem hiding this comment.
Instead of explaining this in the data_description, I would just move the social part to the description of the step itself.
"This has to be an Ohme account. If you signed up with Ohme with a third party account like Google, please reset your password via Ohme, so you can create your own account"
I am probably cutting edges, but let's make it a little more descriptive. Bonus points if we can have a separate place on the integration docs where we explain this
joostlek
reviewed
Dec 14, 2024
joostlek
approved these changes
Dec 14, 2024
13 tasks
zweckj
pushed a commit
to zweckj/home-assistant-core
that referenced
this pull request
Dec 15, 2024
|
@dan-r If you use discord, can you please send me a message? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds a new integration for Ohme, a UK-based company that manufactures EV chargers (EVSE). I have been maintaining this integration as a custom integration for the past year. Before submitting this I have moved the API logic to ohmepy.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: