Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TP-Link powerline and Archer C7 device trackers #14801

Closed
wants to merge 1 commit into from

Conversation

Onager
Copy link

@Onager Onager commented Jun 3, 2018

Description:

Add two new TP-Link device trackers

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @Onager,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@rytilahti
Copy link
Member

I suppose this has been mentioned earlier in other tplink related PRs, but I'd say it's time for someone to step up and create a library from the device specific communication and make this platform use that instead of having this all inside homeassistant's code base...

@amelchio
Copy link
Contributor

amelchio commented Jun 6, 2018

Right, it has been mentioned/decreed before and a basic library actually already exists. So we should start using that.

@Onager I hope you are not put down by this, it's just that you picked a module already in bad shape for your first contribution.

@Onager Onager closed this Jun 7, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants