-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to set options and system options on entry create #27044
Conversation
Not sure if passing through |
@@ -219,6 +220,7 @@ def async_create_entry( | |||
"data": data, | |||
"description": description, | |||
"description_placeholders": description_placeholders, | |||
**kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan because it feels weird. Data should be the data for the config entry, all other is metadata about the step.
Not sure what the correct thing is .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever way that makes it possible to set disable_new_entities to True for a newly created config entry works for me. I wouldn't want to handle disabling the entities manually, and it would be weird if the UI shows new entities being enabled by default where in fact they are created disabled.
Anyway, not sure I understand your concern, but I do think this (options and system_options) is stuff about the config entry, it's not a step thing. It gets persistent with the config entry, UI shows the new entity enablement toggle for the entry, etc.
Or maybe you're concerned about opening the big kwargs possibility to data_entry_flow? As mentioned, that could be left alone and replaced by doing this in ConfigFlow just for options and system_options.
Alternative approach: #27612 |
Withdrawing due to concerns, and #26675 uses a different/selective approach now. |
Description:
Make it possible to create config entries with an initial set of options and system options. This is especially useful on config import, and for some integrations it would be desirable to disable new entities by default as discussed in #26675.
Related issue (if applicable): #26675, #27612 (alternative approach)
Checklist:
tox
. Your PR cannot be merged unless tests pass