Fixes/zha ieee tail #28160
Merged
Fixes/zha ieee tail #28160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
Hacktoberfest
has-tests
integration: zha
small-pr
|
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
Adminiuga
removed
Hacktoberfest
cla-signed
has-tests
small-pr
Adminiuga
force-pushed
the
fixes/zha-ieee-tail
branch
from
ec56f94 to
69ac2d3
Compare
Adminiuga
force-pushed
the
fixes/zha-ieee-tail
branch
from
69ac2d3 to
e111956
Compare
dmulcahey
approved these changes
Oct 24, 2019
balloob
pushed a commit
that referenced
this pull request
Oct 24, 2019
* Fix ZHA entity_id assignment. * Update tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes regression introduced in #27972 Use unique part of IEEE address to generate a part of entity_id.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.