Change keys for samsung TV Next and Prev Track

[tulindo]

Breaking Change:

Changed behaviour for next and previous track command for samsung TV's

Description:

Currently the samsung tv component react to the two above command sending the KEY_FF and KEY_REWIND command. While watching TV programs those two command do nothing.
This patch sends the KEY_CHUP and KEY_CHDOWN commands instead.
The best solution would be to send the right command based on the status of the TV (just like in the LG webos component) but unluckily looks like there is no way to detect what the TV currently showing.
Since there is no next/prev command in the media player but only next/prev track one has to deal with this.
Another option can be the introduction of a new configuration parameter (for samsungtv component) that allows the user to choose between the two alternative behaviour.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[tulindo]

@MartinHjelmare no idea why black tests fails.
In my local development tox says there are no errors.
I ran also
black --fast homeassistant tests
and no complains
Development and test environment is created following https://developers.home-assistant.io/docs/en/development_environment.html and https://developers.home-assistant.io/docs/en/development_testing.html

Do I miss something in my setup? Something to update?
Thanks,
Paolo
PS:
tox version: 3.14.0
black version: 19.3b0

[tulindo]

Looks like PR #28171 fixed black issues.
@MartinHjelmare once that PR will be merged will this PR be rechecked again?

[florisvdk]

No, the checks will have to be manually started again. And from the looks of it not everyone can do that.

[MartinHjelmare]

The PR to fix formatting on dev branch is merged. Try rebasing on latest dev branch to let the build pass.

[kennedyshead]

This is kind of fun... I just looked into this :D

[dgomes]

Since this effectively changes the current behaviour, shouldn't this be labeled as a breaking-change ?

[tulindo]

@dgomes label it as breaking changes is up to me or to the reviewers?

[dgomes]

It's up to reviewers, it's just a matter of making sure that on the blog post of the release users get notified of the change in behaviour.

[tulindo]

Made mistakes trying to resolve conflicts. open a clean new one.