SSDP matching improvements #28285
Merged
SSDP matching improvements #28285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support multiple match groups per domain - require matches on all, not any item in a group - support matching on all UPnP device description data
probot-home-assistant
bot
added
has-tests
integration: ssdp
small-pr
This was referenced Oct 28, 2019
|
This has some issues still, will address, marking as WIP meanwhile. |
|
WIP lifted, hopefully got it right now. |
balloob
approved these changes
Nov 2, 2019
|
🎉 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
ssdpin manifest.json has changed; it is now a list of dicts, and as we now match using the UPnP device description fields directly,device_typehas to be renamed todeviceType. Not sure if custom integrations support this stuff in the first place, but if they do, they need to adjust accordingly. No included integrations use it at the moment, nor are they broken by this change.Description:
Per discussion in #28214 (comment)
Matching on all UPnP device description data is consistent with providing all of it, ditto the
ssdpdata structure in manifest.json to the corresponding provided discovery_info, see #28197Related issue (if applicable): #28214
Pull request with documentation for developer docs: home-assistant/developers.home-assistant#341
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: