Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temperature units to MQTT Climate #30602

Closed
wants to merge 1 commit into from
Closed

Add temperature units to MQTT Climate #30602

wants to merge 1 commit into from

Conversation

panctronic
Copy link

Description:

Modifies the MQTT climate component to support auto-discovered MQTT Climate devices configuring which temperature unit they use. This allows a HVAC unit that internally operates in Celsius to work with a HA installation with a Fahrenheit unit configuration.

Related issue (if applicable): fixes #30600

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11684

Example entry for configuration.yaml (if applicable):

n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • [ x Tests have been added to verify that the new code works.

Modifies the MQTT climate component to support auto-discovered MQTT Climate devices configuring which temperature unit they use. This allows a HVAC unit that internally operates in Celsius to work with a HA installation with a Fahrenheit unit configuration.
@panctronic panctronic requested a review from a team as a code owner January 9, 2020 01:32
@homeassistant
Copy link
Contributor

Hi @panctronic,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to the PLATFORM_SCHEMA and add tests.

@panctronic panctronic closed this Feb 5, 2020
@lock lock bot locked and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT Climate devices do not have a way to express temperature units
3 participants