Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i/o in august camera async image update #32044

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 20, 2020

Breaking change

Proposed change

I don't think this should be doing IO in async_camera_image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco
Copy link
Member Author

bdraco commented Feb 20, 2020

CI failure seems unrelated. force pushing to force another run

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@6c9d4a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev   #32044   +/-   ##
======================================
  Coverage       ?   94.71%           
======================================
  Files          ?      766           
  Lines          ?    55568           
  Branches       ?        0           
======================================
  Hits           ?    52631           
  Misses         ?     2937           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9d4a6...fa008b4. Read the comment docs.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@MartinHjelmare MartinHjelmare merged commit 6e74ee7 into home-assistant:dev Feb 21, 2020
@balloob
Copy link
Member

balloob commented Feb 21, 2020

Is this depending on any PR that was merged since we cut the beta 24 hours ago? Or should we tag this for 106?

@bdraco
Copy link
Member Author

bdraco commented Feb 21, 2020

@balloob. It’s not tied to the other PRs and should backport cleanly

@MartinHjelmare MartinHjelmare added this to the 0.106.0 milestone Feb 21, 2020
balloob pushed a commit that referenced this pull request Feb 22, 2020
* Fix i/o in august camera image update

* Address review comments
@lock lock bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants