-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix i/o in august camera async image update #32044
Conversation
9cddce4
to
fa008b4
Compare
CI failure seems unrelated. force pushing to force another run |
Codecov Report
@@ Coverage Diff @@
## dev #32044 +/- ##
======================================
Coverage ? 94.71%
======================================
Files ? 766
Lines ? 55568
Branches ? 0
======================================
Hits ? 52631
Misses ? 2937
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Is this depending on any PR that was merged since we cut the beta 24 hours ago? Or should we tag this for 106? |
@balloob. It’s not tied to the other PRs and should backport cleanly |
* Fix i/o in august camera image update * Address review comments
Breaking change
Proposed change
I don't think this should be doing IO in async_camera_image
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: