-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Supervisor discovery to motionEye #50901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KapJI
reviewed
May 20, 2021
dermotduffy
reviewed
May 21, 2021
Rebased this PR onto the latest dev. I can now start doing a full end-2-end test, so I can get this PR ready for review/merge. |
9 tasks
Needs #50965 to fix CI. |
dermotduffy
reviewed
May 22, 2021
[Besides the failing CI] This looks great, one minor comment added. Thank you for working on this! |
|
dermotduffy
approved these changes
May 22, 2021
Rebased onto the latest dev, in order to make the tests pass. |
MartinHjelmare
approved these changes
May 26, 2021
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add Supervisor discovery of the motionEye integration, when an add-on is installed that provides motionEye.
Supervisor support was added in home-assistant/supervisor#2850 and is currently in dev/beta to go for stable before Core 2021.6 ships.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: