Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Supervisor discovery to motionEye #50901

Merged
merged 7 commits into from
May 26, 2021
Merged

Add Supervisor discovery to motionEye #50901

merged 7 commits into from
May 26, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented May 20, 2021

Proposed change

Add Supervisor discovery of the motionEye integration, when an add-on is installed that provides motionEye.

Supervisor support was added in home-assistant/supervisor#2850 and is currently in dev/beta to go for stable before Core 2021.6 ships.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck
Copy link
Member Author

frenck commented May 22, 2021

Rebased this PR onto the latest dev. I can now start doing a full end-2-end test, so I can get this PR ready for review/merge.

@frenck
Copy link
Member Author

frenck commented May 22, 2021

image

The discovered integration instance is not ignorable, this is a bug in the frontend. Tests have been included to show it works from the backend.

@frenck
Copy link
Member Author

frenck commented May 22, 2021

image

image

Works as expected ✅ Marking PR ready for review/merge.

@frenck frenck marked this pull request as ready for review May 22, 2021 16:33
@frenck
Copy link
Member Author

frenck commented May 22, 2021

Needs #50965 to fix CI.

@dermotduffy
Copy link
Contributor

[Besides the failing CI] This looks great, one minor comment added. Thank you for working on this!

@frenck
Copy link
Member Author

frenck commented May 22, 2021

  • Rebased to fix CI
  • Adjusted config entry title

@frenck
Copy link
Member Author

frenck commented May 26, 2021

Rebased onto the latest dev, in order to make the tests pass.

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@frenck frenck merged commit 19c505c into dev May 26, 2021
@frenck frenck deleted the frenck-2021-1574 branch May 26, 2021 15:40
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants