-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for missing cleaning time in roomba #51163
Add workaround for missing cleaning time in roomba #51163
Conversation
Hi @GitHub-Action, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
I have been regularly rebasing onto |
No, please don't squash. We'll squash when merging. You can even just commit the review suggestions directly with github to make review even easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please sort the imports with isort. |
Done 👍 Not sure how those got out of sorts... probably have been that way for a long time 😅 |
Thank you! |
Looks like this caused a regression
|
Fixed in #51554 |
Thanks for that @bdraco 👍 In the near future, I'm going to continue to pursue the cleaned area statistic to see if there's anything that can be done about that one as well. |
No hablo bien el inglés soy de mexico y requiero apoyo en la traducción de cómo solucionar y configurar mi dispositivo |
Proposed change
This adds a simple "workaround" to calculate
cleaning_time
for robots which no longer report it in their state. This seems to be a due to to a recent change in the response from iRobot's firmware, in which the robot no longer reports "cleaning time" or "cleaned area".Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: