-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow binary sensor state to be None #60193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
has-tests
integration: binary_sensor
small-pr
PRs with less than 30 lines.
labels
Nov 23, 2021
This was referenced Nov 23, 2021
frenck
force-pushed
the
frenck-2021-3058
branch
from
November 24, 2021 20:43
c7f20fc
to
dfbace6
Compare
frenck
force-pushed
the
frenck-2021-3058
branch
from
December 21, 2021 11:45
dfbace6
to
1dd172d
Compare
5 tasks
frenck
requested review from
Danielhiversen,
elupus,
emontnemery,
janiversen,
robbiet480 and
a team
as code owners
December 21, 2021 17:29
elupus
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good i think. At least from rfxtrx perspective.
MartinHjelmare
approved these changes
Dec 21, 2021
frenck
force-pushed
the
frenck-2021-3058
branch
from
December 22, 2021 10:41
96a6af5
to
50bb803
Compare
Rebased to deal with a merge conflict in the tasmota integration |
MartinHjelmare
approved these changes
Dec 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking-change
cla-signed
core
has-tests
integration: binary_sensor
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Previously,
binary_sensor
entities could have the stateon
oroff
, and in case the device was unreachable:unavailable
. However, compared to other entities, it wasn't able to have theunknown
state, which has been added.So, a
binary_sensor
entity can now have theon
,off
,unavailable
, orunknown
state.You might need to adapt your automations or scripts to take this new
unknown
state into account.Proposed change
Binary sensors currently cannot have a
None
state value (which translates to an "unknown" state). This PR adjusts that.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: