-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump xiaomi_miio dependency #60650
Bump xiaomi_miio dependency #60650
Conversation
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
Hey there @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
Looks like tzlocal (or something else?) started to suddenly fail on python3.8, created issue at Squachen/micloud#5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The time zone system error problem in Python 3.8 seems to only occur in our CI tests for Python 3.8. Local tests can't reproduce. Weird one. We can probably merge here since that problem is unrelated and this PR didn't introduce it. |
Agreed, lets merge it an see what happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rytilahti 👍
Proposed change
Bump python-miio dependency to the new version, changelog available at https://github.com/rytilahti/python-miio/releases/tag/0.5.9
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: