Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugwise module to 0.17.2 #68908

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Update plugwise module to 0.17.2 #68908

merged 3 commits into from
Mar 30, 2022

Conversation

CoMPaTech
Copy link
Contributor

Proposed change

Update plugwise module to 0.17.2 for bugfixes (legacy anna support, improved handling of select entity functionality from earlier PR, IPv6 discovery/zeroconf). Full Changelog also available

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Fixes mentioned issue and IPv6 resolving. The module update has other new functionality that will be implemented in different PRs when ready.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following [Integration Quality Scale][quality-scale]:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

@probot-home-assistant
Copy link

Hey there @bouwew, @brefra, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CoMPaTech & @bouwew 👍

@frenck frenck merged commit 3590467 into home-assistant:dev Mar 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2022
@CoMPaTech CoMPaTech deleted the pw_017 branch March 13, 2023 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Assistant Community Plugwise Anna unavailable after updating to 2022.3
4 participants