Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set a stun server for RTSPtoWebRTC #72574

Merged
merged 6 commits into from
Oct 4, 2022

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented May 27, 2022

Proposed change

Add a configuration option to set a stun server for RTSPtoWebRTC, and a websocket exposed so that the javascript frontend webrtc player can fetch it.

Frontend PR: home-assistant/frontend#13942

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • [X} There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@allenporter
Copy link
Contributor Author

Converting to draft as I need to add translations.

@allenporter allenporter marked this pull request as ready for review May 30, 2022 00:26
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 22, 2022
@balloob
Copy link
Member

balloob commented Jun 29, 2022

Can be merged if frontend pR is ready

@frenck frenck added awaiting-frontend and removed smash Indicator this PR is close to finish for merging or closing labels Jun 29, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@allenporter
Copy link
Contributor Author

I've sent a new version of a frontend PR that uses this in home-assistant/frontend#12084

@allenporter
Copy link
Contributor Author

I've made a few updates to the config flow. This can use another look, though frontend PR that depends on this has not yet been reviewed.

@allenporter allenporter requested a review from balloob October 1, 2022 20:20
@allenporter
Copy link
Contributor Author

The frontend PR has been approved: home-assistant/frontend#13942 and this is ready for another review after some updates/test improvements related to the options flow.

@balloob balloob merged commit 90637a7 into home-assistant:dev Oct 4, 2022
@balloob balloob added this to the 2022.10.0 milestone Oct 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants