Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure numeric sensors have a valid value #85605

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jan 10, 2023

Proposed change

DO NOT MERGE BEFORE 2023.4.0dev
As follow-up to #85513 and #85863, we can now validate numeric sensors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign sensor Removes the current integration label and assignees on the issue, add the integration domain after the command.

@epenet epenet marked this pull request as draft January 10, 2023 13:03
@epenet
Copy link
Contributor Author

epenet commented Jan 10, 2023

cc @mib1185 / @flabbamann
I am not sure how to fix the fritzbox tests for this.
https://github.com/home-assistant/core/actions/runs/3885198937/jobs/6629601875

@mib1185
Copy link
Contributor

mib1185 commented Jan 10, 2023

@epenet the fritzbox tests are fixed 😉

@epenet
Copy link
Contributor Author

epenet commented Jan 16, 2023

Since #85863 was merged, I have moved the test fixes to separate PRs

@epenet epenet marked this pull request as ready for review February 24, 2023 09:59
@epenet
Copy link
Contributor Author

epenet commented Feb 24, 2023

2023.4.0dev is out
I think this can be reviewed again now.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 14, 2023
@epenet
Copy link
Contributor Author

epenet commented Mar 17, 2023

Rebased to ensure CI still passes

@epenet
Copy link
Contributor Author

epenet commented Mar 27, 2023

As discussed with @emontnemery and @frenck, marking this as draft until beta is cut, so we have a dev cycle with nightlies to act on

@epenet epenet marked this pull request as draft March 27, 2023 09:32
@epenet epenet removed the smash Indicator this PR is close to finish for merging or closing label Mar 27, 2023
@epenet
Copy link
Contributor Author

epenet commented Mar 29, 2023

2023.5.0dev is out
I think this can be reviewed again now.

@epenet epenet marked this pull request as ready for review March 29, 2023 20:28
@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Mar 29, 2023
@emontnemery emontnemery merged commit ab699d1 into home-assistant:dev Mar 31, 2023
@epenet epenet deleted the sensor-value branch March 31, 2023 12:13
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality core integration: sensor Quality Scale: internal small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants