Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pip_check +1 #86336

Closed
wants to merge 1 commit into from
Closed

Bump pip_check +1 #86336

wants to merge 1 commit into from

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jan 21, 2023

Proposed change

Bump pip_check +1 to fix CI

python-bsblan 0.5.8 has requirement packaging<22.0,>=21.3, but you have packaging 23.0.
pysmarty 0.8 has requirement pymodbus==1.5.2, but you have pymodbus 3.1.0.
paramiko 3.0.0 has requirement bcrypt>=3.2, but you have bcrypt 3.1.7.
mycroftapi 2.0 has requirement websocket-client==0.44.0, but you have websocket-client 1.4.2.
ibm-watson 5.2.2 has requirement websocket-client==1.1.0, but you have websocket-client 1.4.2.

It seems that paramiko 3.0.0 (sub-dependency) was released a few hours ago, and now requires bcrypt>=3.2
paramiko/paramiko@2.12.0...3.0.0

An alternative to this PR is #86338 which bumps bcrypt to the latest version.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor Author

epenet commented Jan 21, 2023

Closed in favor of #86338

@epenet epenet closed this Jan 21, 2023
@epenet epenet deleted the pip-check branch January 21, 2023 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant