-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to fully_kiosk for hybrid local push/pull switches using MQTT #89010
Add support to fully_kiosk for hybrid local push/pull switches using MQTT #89010
Conversation
Hey there @cgarwood, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, but might be good for someone more familiar with MQTT to take a quick look.
Is there anything I can do to get this in someone's queue to get a second review? |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Erik Montnemery <erik@montnemery.com>
@emontnemery I finally got around to finishing the change you requested. Could you please take another look and let me know if there's anything that needs to be fixed for this to get merged? |
@emontnemery Could you take another look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mheath 👍
|
||
topic_template = data["settings"]["mqttEventTopic"] | ||
topic = ( | ||
topic_template.replace("$appId", "fully") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move all the MQTT data and topic parsing to the 3rd party library. The library can accept callbacks for MQTT subscribe and publish that Home Assistant can provide and then the library can handle the logic and parsing as needed.
Breaking change
Proposed change
This is the first step in a larger goal of adding a motion binary sensor to to the Fully Kiosk integration. This commit provides support for using MQTT to update the screen and screen saver switches immediately (when MQTT is enabled in HA and in FKB) instead of waiting to poll the kiosk. Also, there are other entities that could have local push support using MQTT. I will submit PRs for that once this PR is accepted.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: