Remove legacy pip resolver #92124
Merged
Remove legacy pip resolver #92124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
breaking-change
cla-signed
integration: mycroft
integration: smarty
integration: watson_tts
small-pr
|
Hey there @z0mbieprocess, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @rutkai, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
pvizeli
requested changes
Apr 27, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Nice catch! Removed it 👍 |
|
It's a shame that they ignored this issue for years at IBM. I pinged one of the devs, I don't have high hopes, but we may get something (in a few weeks' time). |
pvizeli
approved these changes
Apr 27, 2023
|
back to draft, figure out why test fail (and address the pylint one) |
|
Somehow I end up with Thats what fails for me locally pip seemed to get quite confused about boto3 |
|
Danielhiversen/pyTibber#268 should fix tibber |
|
Thanks, @bdraco 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The legacy pip resolver has been removed. Because of that, the following integrations are no longer compatible with Home Assistant:
The upstream packages that cause conflicts (and thus required us to disable these integrations) have been notified repeatedly in, at least, the past two years, without response.
Proposed change
SSIA, and see the breaking changes section above. Upstream issues:
All of them are older than two years, without resolution. We can't keep extending this.
This PR also removes the
pip_checkjob and script, as this is no longer needed (pipwill fail by itself now).Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: