Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default for add-on options and schema config #771

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 11, 2021

Proposed change

It is always nice if an add-on doesn't need any options (and thus might not have a schema).

This PR adds a default empty dictionaries to the schema and options configuration parameters of an add-on configuration, mainly for cleaner add-on configurations.

For a future improvement, it would be nice if we could expose if the add-on has options (and thus a schema) and hide the config from the UI based on that.

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Removed stale or deprecated documentation

Additional information

@ludeeus
Copy link
Member

ludeeus commented Jan 11, 2021

home-assistant/frontend#8130 for the frontend part.

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Can be merged when the parent PR is merged.

@ludeeus ludeeus merged commit 1de9ef6 into master Jan 11, 2021
@ludeeus ludeeus deleted the frenck-2021-0019 branch January 11, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants