Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.py #11593

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Remove setup.py #11593

merged 1 commit into from
Mar 23, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 7, 2022

Proposed change

With the update to pip>=21.0, it's no longer needed for editable installs.
https://pip.pypa.io/en/stable/news/#id50
Ref: home-assistant/core#59769

PR for core: home-assistant/core#66023

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@frenck
Copy link
Member

frenck commented Feb 7, 2022

Can we hold off on this one, until we have at least a nightly build passed?

ludeeus
ludeeus previously requested changes Feb 7, 2022
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdce8p cdce8p marked this pull request as draft February 7, 2022 16:51
@cdce8p cdce8p marked this pull request as ready for review February 10, 2022 13:05
@cdce8p
Copy link
Member Author

cdce8p commented Feb 10, 2022

The action has been updated and as far as I can tell, the nightly builds are successful.
@frenck This PR is be ready IMO. If you are more comfortable with waiting a bit longer, that would be fine for me too.

* With the update to pip>=21.0, it's no longer needed for editable installs
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

@frenck frenck dismissed ludeeus’s stale review March 23, 2022 08:22

Comment addressed

@frenck frenck merged commit d6a1d5a into home-assistant:dev Mar 23, 2022
@cdce8p cdce8p deleted the remove-setup.py branch March 23, 2022 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants