Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back babel #3974

Merged
merged 3 commits into from
Oct 19, 2019
Merged

Bring back babel #3974

merged 3 commits into from
Oct 19, 2019

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Oct 9, 2019

This PR was open longer than expected because we ran into an issue with properties. Putting it here to make sure we don't forget.

In TypeScript we often declare empty properties to make TS aware of the type:

class Hello {
  public name: string
}

With the latest class fields proposal these should now result in the value undefined being set with a defineProperty (TS issue). This causes any Lit Element setters generated via static get propertes() to be erased.

However, we now run into the issue that we cannot use decorators inside anonymous classes (used by our mixins). So in this PR we add // @ts-ignore to the three impacted mixins.

Fixes #3830

@iantrich
Copy link
Member

iantrich commented Oct 9, 2019

Fix for #3830?

@bramkragten
Copy link
Member Author

Fix for #3830?

Yes, but it is not working yet... 😢

@iantrich iantrich mentioned this pull request Oct 10, 2019
@bramkragten bramkragten merged commit d05dc2e into dev Oct 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the revert-babel branch October 19, 2019 12:06
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load UI on older iOS devices
4 participants