This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 98
Combine upgrade scripts (*-dev) #148
Merged
Landrash
merged 11 commits into
home-assistant:dev
from
ludeeus:combine-installation-scripts
Mar 26, 2018
Merged
Combine upgrade scripts (*-dev) #148
Landrash
merged 11 commits into
home-assistant:dev
from
ludeeus:combine-installation-scripts
Mar 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landrash
suggested changes
Mar 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweak then ready for merge
source /srv/homeassistant/bin/activate | ||
pip3 show homeassistant | ||
if [ "$DEV" == "true" ]; then | ||
echo "This scripts downloads new scripts directly from the dev branch on github." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit out of place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it?
When the --dev flag is used, we do not need to check current version, since this change with every commit?
Landrash
approved these changes
Mar 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition 🥇
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Inspiration from @olskar in #146
This change introduces 2 new command line flags:
-B | --beta
--dev
--beta
is only used forhomeassistant
script, and will install the current RC(Beta) version.--dev
is used both inhassbian-script
andhomeassistant
scripts, and will install the latest dev branch from github.*-dev.sh scripts are removed from the package.
Checklist:
If pertinent:
/docs