Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Combine upgrade scripts (*-dev) #148

Merged
merged 11 commits into from
Mar 26, 2018
Merged

Combine upgrade scripts (*-dev) #148

merged 11 commits into from
Mar 26, 2018

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Mar 25, 2018

Description:

Inspiration from @olskar in #146
This change introduces 2 new command line flags:

  • -B | --beta
  • --dev

--beta is only used for homeassistant script, and will install the current RC(Beta) version.
--dev is used both in hassbian-script and homeassistant scripts, and will install the latest dev branch from github.

*-dev.sh scripts are removed from the package.

Checklist:

  • The code change is tested and works locally.

If pertinent:

  • Created/Updated documentation at /docs
  • [N/A] Script has validation check of the job.

@ludeeus ludeeus requested a review from Landrash March 25, 2018 11:02
@ludeeus ludeeus added this to the v0.9.0 milestone Mar 25, 2018
@ludeeus ludeeus changed the title Combine installation scripts Combine upgrade scripts (*-dev) Mar 25, 2018
Copy link
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak then ready for merge

source /srv/homeassistant/bin/activate
pip3 show homeassistant
if [ "$DEV" == "true" ]; then
echo "This scripts downloads new scripts directly from the dev branch on github."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit out of place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it?
When the --dev flag is used, we do not need to check current version, since this change with every commit?

Copy link
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition 🥇

@Landrash Landrash merged commit 472efca into home-assistant:dev Mar 26, 2018
@ludeeus ludeeus deleted the combine-installation-scripts branch March 26, 2018 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants