Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Documentation #88

Merged
merged 28 commits into from
Feb 6, 2018
Merged

Documentation #88

merged 28 commits into from
Feb 6, 2018

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jan 21, 2018

Moved script documentation from README.md to /docs/*.md
Added an TOC (Table off content) to README.md
DEMO

@Landrash Landrash added this to the v0.7 milestone Jan 27, 2018
@Landrash
Copy link
Collaborator

This will be the "last planed" addition for 0.7 but I'm going to need a bit more time to review it properly. ⏳

@@ -0,0 +1,27 @@
## Description
**This script was broken since packages are not available for Debian Stretch, but we have implemented an workaround that make sure this will run as intended on HASSbian Stretch.**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tad out of date now ;)

Copy link
Member Author

@ludeeus ludeeus Jan 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not when I first made this :) corrected now

@@ -0,0 +1,31 @@
## Description
This script installs an web terminal called 'shellinabox' to you system that give you SSH access in you web browser.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling you=your.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix'd :)


## Installation
```
$ curl https://api.github.com/repos/home-assistant/hassbian-scripts/releases/latest | grep "browser_download_url.*deb" | cut -d : -f 2,3 | tr -d \" | wget -qi -
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rewritten to recommend installing the image instead to reflect that it exists. The command line option could be left as an alternative but have a warning that if it's used with anything else than Raspbian or Hassbian it might not function as intended.

Copy link
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor additions should be added but looks great in general 👍

@@ -0,0 +1,31 @@
## Description
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be extended a bit.
Documentation about the flags like -y & -t are missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this PR was created, those flags did not exist :)
They are added now :)

hassbian-config *command* *suite*
```
where command is one of:
- `install`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation about each command could be extended.

- `show`
- `log`
- `share-log`
- `install` Use this to isntall an suite.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling of install

- `upgrade` Use this to upgrade an installed suite.
- `show` This will show you all available suites.
- `log` This wil show you the log of last hassbian-config operation.
- `share-log` This wil generate an hastebin link of the last hassbian-config operation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling of will.

- `install` Use this to isntall an suite.
- `upgrade` Use this to upgrade an installed suite.
- `show` This will show you all available suites.
- `log` This wil show you the log of last hassbian-config operation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling of will.

- `log` This wil show you the log of last hassbian-config operation.
- `share-log` This wil generate an hastebin link of the last hassbian-config operation.

optional flags:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital letter of Optional.


optional flags:
- `-y` This will accept defaults on scripts that allow this.
- `-f` This will force run an script, usefull is you try to install something a second time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend rephrasing this a bit.
"This will force run an script. This is useful if you need to reinstall a package."


## Installation
This package is installed in the [HASSbian image](https://github.com/home-assistant/pi-gen/releases), so you do not need to install it there.
This will probably work on other distros also, but testing will only be done on HASSBian, therefor no support will be given if you choose to install it elsewhere.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line. I'm fairly certain it wont work on most others. An optional sentence.

This package is pre-installed on the [HASSbian image](https://github.com/home-assistant/pi-gen/releases).
This package can be used with Raspbian lite but it's not recommended.

Copy link
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the changes applied 👍

@Landrash Landrash merged commit c2162a4 into home-assistant:dev Feb 6, 2018
@ludeeus ludeeus deleted the Documentation branch February 6, 2018 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants