Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Combine install/upgrade scripts, and new arguments. #90

Merged
merged 16 commits into from
Feb 4, 2018
Merged

Combine install/upgrade scripts, and new arguments. #90

merged 16 commits into from
Feb 4, 2018

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jan 28, 2018

  • All scripts has been renamed, they are no longer prefix'd by install_ / upgrade_.

  • If there was an install and upgrade script, these are now combined.

  • functions in hassbian-config is updated to new structure.

  • Add command line option -f to to force scripts.
    image

  • Add command line option -y to to accept pormts.

    • add -y option to share-log function
    • add -y option to mosquitto installer
    • add -y option to homebridge
    • add -y option to appdaemon

@ludeeus ludeeus changed the title Combine install/upgrade scripts. WIP: Combine install/upgrade scripts. Jan 28, 2018
@ludeeus ludeeus changed the title WIP: Combine install/upgrade scripts. WIP: Combine install/upgrade scripts, and new arguments. Jan 28, 2018
@ludeeus
Copy link
Member Author

ludeeus commented Jan 28, 2018

If user input is required, like in the duckdns script, they do not need an implementation for -y
But in scripts like mosquitto and homebridge we ca implement it by adding this for the parts that can have default values:

if [ "$ACCEPT" == "true" ]; then
  #Do this if -y is active
  mqtt_username=pi
else
  #Do this if -y is not active
  echo -n "Username: "
  read mqtt_username
fi

@ludeeus ludeeus changed the title WIP: Combine install/upgrade scripts, and new arguments. Combine install/upgrade scripts, and new arguments. Jan 28, 2018
Copy link
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging into dev.

@Landrash Landrash merged commit ca7528a into home-assistant:dev Feb 4, 2018
@ludeeus ludeeus deleted the combine-scripts branch February 4, 2018 19:50
@ludeeus ludeeus added this to the v0.7 milestone Feb 4, 2018
quenbert referenced this pull request in home-assistant/home-assistant.io Mar 12, 2018
Line 40 Change:
You can also use `hassbian-config` to automate the process by running `sudo hassbian-config upgrade homeassistant`
to
You can also use `hassbian-config` to automate the process by running `sudo hassbian-config upgrade home-assistant`
as this was incorrect
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants