Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Huawei LTE, add UI config, unauthenticated mode, switch #10380

Merged
merged 13 commits into from
Nov 4, 2019

Conversation

scop
Copy link
Member

@scop scop commented Sep 16, 2019

Description:

See main HA PR for details.

Pull request in home-assistant (if applicable): home-assistant/core#26675 and home-assistant/core#28188 and home-assistant/core#28214

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Sep 16, 2019
@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed labels Sep 16, 2019
@scop scop force-pushed the huawei-lte-modernize branch from 6508190 to d03e67a Compare October 5, 2019 17:02
@probot-home-assistant probot-home-assistant bot added the parent-merged The parent PR has been merged already label Oct 24, 2019
@scop scop changed the title Modernize Huawei LTE, add UI config, switch, unauthenticated mode Modernize Huawei LTE, add UI config, unauthenticated mode Oct 24, 2019
@scop scop mentioned this pull request Oct 25, 2019
2 tasks
@scop scop changed the title Modernize Huawei LTE, add UI config, unauthenticated mode Modernize Huawei LTE, add UI config, unauthenticated mode, switch Oct 26, 2019
@scop scop force-pushed the huawei-lte-modernize branch from ac5355b to 02acad1 Compare October 26, 2019 10:34
@scop scop mentioned this pull request Oct 26, 2019
2 tasks
fabaff
fabaff previously approved these changes Nov 4, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @scop! Left a small comment, could you take a look? Thanks! 👍

source/_integrations/huawei_lte.markdown Outdated Show resolved Hide resolved
source/_integrations/huawei_lte.markdown Outdated Show resolved Hide resolved
source/_integrations/huawei_lte.markdown Outdated Show resolved Hide resolved
@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Nov 4, 2019
@scop
Copy link
Member Author

scop commented Nov 4, 2019

With home-assistant/core#28214 just merged as well, I've merged #10992 here as well, hope you don't mind.

@frenck frenck unassigned scop Nov 4, 2019
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Nov 4, 2019
@scop
Copy link
Member Author

scop commented Nov 4, 2019

Wondering if the netlify preview check is stuck or something...?

@frenck
Copy link
Member

frenck commented Nov 4, 2019

@scop No, it is not 😉

Old and new Netlify profiles on this PR still.

@frenck frenck merged commit 50ca49b into home-assistant:next Nov 4, 2019
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Nov 4, 2019
@scop scop deleted the huawei-lte-modernize branch November 4, 2019 21:11
@scop
Copy link
Member Author

scop commented Nov 4, 2019

Ah, just inpatient then :) Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants