Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect mapping of DT overlays on RPi 5 #3335

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

sairon
Copy link
Member

@sairon sairon commented Apr 29, 2024

RPi 5 config uses BR2_LINUX_KERNEL_INSTALL_INTREE_OVERLAYS which builds the device tree overlays from the Linux tree when building the kernel. The overlays directory also contains overlay_map.dtb which is necessary to correctly map overlays without RPi version suffix to the platform-specific ones. Without this, some peripherals may not work correctly on Pi 5 without any obvious error messages in the kernel log because an incorrect (Pi 4) overlay is used as the default.

Fixes #3321

  • buildroot cc0481f40e...0a64bfe8f1 (1):

    Install overlay_map.dtb when using in-tree DT overlays

RPi 5 config uses BR2_LINUX_KERNEL_INSTALL_INTREE_OVERLAYS which builds
the device tree overlays from the Linux tree when building the kernel.
The overlays directory also contains overlay_map.dtb which is necessary
to correctly map overlays without RPi version suffix to the
platform-specific ones. Without this, some peripherals may not work
correctly on Pi 5 without any obvious error messages in the kernel log
because an incorrect (Pi 4) overlay is used as the default.

Fixes #3321

* buildroot cc0481f40e...0a64bfe8f1 (1):
  > Install overlay_map.dtb when using in-tree DT overlays
@sairon sairon added the board/raspberrypi Raspberry Pi Boards label Apr 29, 2024
@sairon sairon requested a review from agners April 29, 2024 13:19
@sairon sairon merged commit fce19b7 into dev Apr 29, 2024
2 checks passed
@sairon sairon deleted the fix-rpi-intree-overlay-mapping branch April 29, 2024 13:20
jens-maus added a commit to jens-maus/RaspberryMatic that referenced this pull request Apr 29, 2024
sairon added a commit that referenced this pull request Apr 30, 2024
RPi 5 config uses BR2_LINUX_KERNEL_INSTALL_INTREE_OVERLAYS which builds
the device tree overlays from the Linux tree when building the kernel.
The overlays directory also contains overlay_map.dtb which is necessary
to correctly map overlays without RPi version suffix to the
platform-specific ones. Without this, some peripherals may not work
correctly on Pi 5 without any obvious error messages in the kernel log
because an incorrect (Pi 4) overlay is used as the default.

Fixes #3321

* buildroot cc0481f40e...0a64bfe8f1 (1):
  > Install overlay_map.dtb when using in-tree DT overlays

(cherry picked from commit fce19b7)
@sairon sairon mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/dev/dri is missing on the RPi 5
2 participants