-
-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rauc hook to restore machine-id in new grub environment #3451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I'd like to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, you got it right. In fact, the same issue started to manifest in latest dev builds for OVA/x86 as a result of #3435. However, I'll prefer to do it differently - instead of amending the grubenv
distributed in the update bundle, preserve it as whole - in the same way as we do with the *.txt
files (which we use for persisting machine-id on non-grub platforms).
Without a machine-id, the next boot will be considered as a first boot, and any external data disk will be disabled. Fixes home-assistant#3247.
30c4373
to
ac31ff2
Compare
Hi @sairon, that works even better, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, thank you!
Tagging with generic-aarch64 only, since x86/OVA targets were not affected until the patch that landed just recently only in dev. |
Without a machine-id, the next boot will be considered as a first boot, and any external data disk will be disabled.
Fixes #3247.
After installing my raucb update bundle and a reboot:
The machine-id has been conserved 👍