-
-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use EROFS for the root filesystem #3456
Conversation
2958c58
to
889fb30
Compare
Paths for images generated outside of genimage were not used in genimage definitions. Use them as the single source of truth. Images generated by genimage itself (e.g. kernel.img) don't need to use those functions, so remove the unused ones.
* Enabled EROFS in common kernel fragment * RootFS image switched to EROFS with options to get decent compression * rootfstype removed from kernel command line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Looking forward to that one 🤩 .
Hey @sairon, First question that comes to my mind is whether a user can check with which OS version (and on which date) the initial setup was carried out. @agners is that visible anywhere in Supervisor, and should it? If this line of question makes sense to you I'd be happy to raise it in a more appropriate place, e.g. under discussions. Apologies if a discussion thread on this already exists. |
Hi @ThomDietrich 👋
You're not quite right. This changes the whole rootfs partition which is read-only and gets changed also for existing installations (you can check On the other hand, sometimes there are changes that do not make its way to existing installations. Generally it'd be changes of the partitioning, or changes in |
Hey @sairon, thanks for the long response! |
Switch to EROFS for the root filesystem, which promises better performance than SquashFS and with proper options set, it even achieves better compression.
Some hard numbers proving it's better choice are yet to be gathered but so far it looks fine.