Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return noerror if any answers found (A or AAAA) #81

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Return noerror if any answers found (A or AAAA) #81

merged 1 commit into from
Mar 4, 2022

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Mar 3, 2022 •
edited
Loading

Must always return a NOERROR response if we found any A or AAAA responses, even if we didn't find any which answered their question (i.e. A answers only for an AAAA query). Returning an NXDOMAIN for AAAA but not A (or vice versa) breaks musl.

@mdegat01 mdegat01 added the bug Something isn't working label Mar 3, 2022
@mdegat01 mdegat01 requested a review from pvizeli March 3, 2022 19:26
@scooper1
Copy link

scooper1 commented Mar 3, 2022

a quick look at changes
seems to list 10. and 192.168 local addresses but not 172.16

@pvizeli pvizeli merged commit 96a587b into master Mar 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the noerror-ipv6-musl branch March 4, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdegat01 @scooper1 @pvizeli @homeassistant