Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more domains to entityComponents #191

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Add more domains to entityComponents #191

merged 2 commits into from
Jun 19, 2023

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jun 17, 2023

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add image now too :)

@home-assistant home-assistant bot marked this pull request as draft June 19, 2023 17:43
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ludeeus
Copy link
Member Author

ludeeus commented Jun 19, 2023

@frenck
Copy link
Member

frenck commented Jun 19, 2023

Yes: home-assistant/core#90564

The dev docs has an open comment on the PR, which should resolved soon.

../Frenck

@ludeeus
Copy link
Member Author

ludeeus commented Jun 19, 2023

Oh. That new.

@ludeeus ludeeus marked this pull request as ready for review June 19, 2023 20:34
@home-assistant home-assistant bot requested a review from frenck June 19, 2023 20:34
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frenck frenck merged commit 76a42d8 into main Jun 19, 2023
@frenck frenck deleted the entityComponents branch June 19, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants