Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MessageCommand command to Discord bot #20

Merged
merged 3 commits into from
Sep 25, 2022
Merged

Add MessageCommand command to Discord bot #20

merged 3 commits into from
Sep 25, 2022

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Sep 18, 2022 •
edited
Loading

  • Adds /message message:key to post predefined messages.
    • This have the same autocomplete feature as /integration
  • Adds ./data/discord_messages.yaml so that messages can be added/changed without needing a redeployment
    • YAML over JSON because its easier to write/read, especially with multiline content.

@ludeeus ludeeus changed the title Add message command Add MessageCommand command to Discord bot Sep 21, 2022
balloob
balloob reviewed Sep 25, 2022
View reviewed changes
services/bots/src/discord/commands/message.ts Outdated
return;
}
try {
await this.reloadMessageData();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call it ensureMessageDataLoaded

@ludeeus ludeeus merged commit c36ea75 into main Sep 25, 2022
@ludeeus ludeeus deleted the message branch September 25, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludeeus @balloob @homeassistant