Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node-fetch dependency #212

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Remove node-fetch dependency #212

merged 1 commit into from
Oct 9, 2023

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Oct 9, 2023

NodeJS now ships with fetch on the global namespace. https://nodejs.org/docs/latest-v20.x/api/globals.html

So, there is no reason to keep this package as a dependency anymore.

@ludeeus ludeeus merged commit 47a2043 into main Oct 9, 2023
3 checks passed
@ludeeus ludeeus deleted the remove_node_fetch branch October 9, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludeeus @frenck