Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import all old commands #63

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Import all old commands #63

merged 2 commits into from
Oct 3, 2022

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Oct 3, 2022

@@ -1,3 +1,1664 @@
hello_world:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we drop this one as we no longer need a placeholder ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only one that show a description

* Core requires you to [activate the venv
first](https://www.home-assistant.io/common-tasks/core/#configuration-check)
list:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can go

Copy link
Member Author

@ludeeus ludeeus Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We import all and adjust later or nothing
70-80 % needs adjustments or can be removed.

tts:
content: >-
If `tts` isn't working in your media players (and on a Google device at most
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cogneato once this PR is merged, can you go through these snippets and update them to latest knowledge/UI. For example, this one needs to use a My link to point at https://my.home-assistant.io/redirect/network/ instead.

Or don't, and just wait for the recipient to get annoyed enough to block
you.
raccoon:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hide commands from auto-complete?

And maybe we can also drop some. (in a future PR maybe). Do we really need bot commands to promote individual repo's?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes
No

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f605718 hides commands from auto complete if they are missing a description (all imported commands are currently missing that)

@balloob balloob merged commit a86df8f into main Oct 3, 2022
@balloob balloob deleted the import-old-commands branch October 3, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants