Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backups/manager: Emit supervisor update events on backup start/end #3599

Closed
wants to merge 1 commit into from

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Apr 27, 2022

Proposed change

Send supervisor events to core when backups have been started and
finished so that it's possible to create automations based on such
events.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@3v1n0 3v1n0 force-pushed the backup-events branch 3 times, most recently from 327edc2 to dc46e6e Compare April 27, 2022 15:59
Send supervisor events to core when backups have been started and
finished so that it's possible to create automations based on such
events.

Closes home-assistant#2193
@3v1n0
Copy link
Contributor Author

3v1n0 commented Apr 27, 2022

Something is wrong with CI... It doesn't get the cla-signed label and it fails on getting the base branch...

@pvizeli
Copy link
Member

pvizeli commented Apr 27, 2022

Thanks for your contribution. If you like to have something like this, feel free to implement the RFC for this.
#1946

@pvizeli pvizeli closed this Apr 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Snapshot complete event
4 participants