-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tesla custom integration #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integration collides with a core integration. Suggestion to change its domain.
Additionally, it relies on packages that are also dependent on in the core. This may cause a breakage when dependencies get out of sync. The suggestion is to depend on those requirements using a range instead of a specific version.
It's meant as a replacement to core. You can't run both at the same time. By forcing an override, it makes it clear. For the dependency, are you talking about teslajsonpy or the subdependencies under that? |
It isn't clear, we have the same issue with
|
I can change the domain but the custom component won't work with a lower version of |
Yeah you could pin in a range like: That said, if you have a requirement range that doesn't include the dependency of the core, it might lead to problems for end-users. |
This was required by home-assistant/wheels-custom-integrations#383 (comment) Tesla in core will be non-functional regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @alandtse 👍
../Frenck 🚂
No description provided.