Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiogithubapi #704

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add aiogithubapi #704

merged 1 commit into from
Sep 27, 2024

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Sep 13, 2024

@frenck
Copy link
Member

frenck commented Sep 13, 2024

This requires already published a wheel:

CleanShot 2024-09-13 at 09 18 09@2x

This wheel isn't architecture-dependent (a universal wheel).

Any reason why we need to include it here at this point?

../Frenck

@ludeeus
Copy link
Member Author

ludeeus commented Sep 13, 2024

uv with extra index url requires the wheel to exist on the specified server.
Example https://github.com/hacs/integration/actions/runs/10844324465/job/30092983137

@frenck
Copy link
Member

frenck commented Sep 13, 2024

Hmmm that almost sounds like an issue with uv, as it almost looks like it behaves as if you set UV_INDEX_URL (while you did set UV_EXTRA_INDEX_URL). It should honor the existing index when setting an extra index.

@ludeeus
Copy link
Member Author

ludeeus commented Sep 13, 2024

If the package does not exist, it will happily reach out to pypi.
But if the package exist but requested version of that package does not exist, it does not.
Unless you override the behavior with an unsafe option.

https://docs.astral.sh/uv/reference/settings/#index-strategy

@frenck
Copy link
Member

frenck commented Sep 27, 2024

Check, let's do this for now.

../Frenck

@frenck frenck merged commit 91194c0 into master Sep 27, 2024
7 checks passed
@frenck frenck deleted the aiogithubapi branch September 27, 2024 12:49
@ludeeus
Copy link
Member Author

ludeeus commented Sep 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants